Skip to content

fix csv parsing problems#452

Draft
josihoppe wants to merge 20 commits intomainfrom
fix/csv_parse_error
Draft

fix csv parsing problems#452
josihoppe wants to merge 20 commits intomainfrom
fix/csv_parse_error

Conversation

@josihoppe
Copy link
Copy Markdown

  • csv files should be able to contain "," delimiter and "," decimal seperators
  • tests should be added for different edge cases of file formatting

@josihoppe josihoppe linked an issue Mar 26, 2026 that may be closed by this pull request
@paulapreuss
Copy link
Copy Markdown

Summary of open points:

  • Tests now run for different timeseries uploads
  • However, there seems to be some mismatches between the frontend and the backend processing
    • When uploading a timeseries file, the timeseries often gets displayed wrong in the plotly window. However, the processing then works correctly, since saving the asset form and then opening it again shows the timeseries graph correctly (I had this issue with the following file and tested both with an index column and without ninja_pv_52.1315_11.6401_corrected.csv)
    • When uploading a timeseries file, some checks are performed in the frontend and some in the backend. For instance, the timeseries length check happens in javascript and displays an error message, however it still allows the user to save the timeseries.

I think the better approach would be to conduct all checks in the backend and display them in the form upon validation. That way we ensure that all checks are in one place and there won't be any values saved that did not pass validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upload of timeseries gives an error when using comma values

2 participants